Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bolt11 invoice string to sent stored payments #209

Merged
merged 1 commit into from
Feb 21, 2024
Merged

feat: add bolt11 invoice string to sent stored payments #209

merged 1 commit into from
Feb 21, 2024

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Feb 9, 2024 •
edited
Loading

Resolves #156

  • Saves invoice string when paying for a bolt11 invoice to sent payments file

On Android also:

  • Returns route hops info in case of PaymentPathSuccessful event (already exists in iOS)

@ovitrif ovitrif changed the title feat: Save bolt11 invoice string to storage feat: Save bolt11 invoice string to payments sent Feb 13, 2024
@ovitrif ovitrif changed the title feat: Save bolt11 invoice string to payments sent feat: Add bolt11 invoice string to sent stored payments Feb 13, 2024
@ovitrif ovitrif force-pushed the feat/persist-bolt11-invoice-string branch from 3fe253a to 4fa0e1c Compare February 14, 2024 16:46
@ovitrif ovitrif changed the title feat: Add bolt11 invoice string to sent stored payments feat: add bolt11 invoice string to sent stored payments Feb 14, 2024
@coreyphillips
Copy link
Collaborator

With the inclusion of bolt11_invoice should we also update the TChannelManagerPaymentSent type?

@ovitrif
Copy link
Contributor Author

ovitrif commented Feb 15, 2024

With the inclusion of bolt11_invoice should we also update the TChannelManagerPaymentSent type?

Indeed, thank you for pointing this out, I'll update the code!

@ovitrif ovitrif force-pushed the feat/persist-bolt11-invoice-string branch 2 times, most recently from 834c4c1 to 969adcc Compare February 16, 2024 03:42
Jasonvdb
Jasonvdb reviewed Feb 20, 2024
View reviewed changes
lib/src/utils/types.ts Outdated Show resolved Hide resolved
@ovitrif ovitrif force-pushed the feat/persist-bolt11-invoice-string branch from 969adcc to 951a04e Compare February 20, 2024 10:45
@ovitrif ovitrif requested a review from Jasonvdb February 20, 2024 10:45
@Jasonvdb Jasonvdb merged commit fa99bb3 into master Feb 21, 2024
6 checks passed
@Jasonvdb Jasonvdb deleted the feat/persist-bolt11-invoice-string branch February 21, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasonvdb Jasonvdb Jasonvdb approved these changes

@coreyphillips coreyphillips Awaiting requested review from coreyphillips

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add bolt11 invoice string to sent/claimed stored payments
3 participants
@ovitrif @coreyphillips @Jasonvdb